PR#1095: Remove specfile translation review item - packaging-committee

packaging-committee

#1095 Remove specfile translation review item

Merged 2 years ago by tibbs. Opened 2 years ago by oturpe.

oturpe/packaging-committee remove-summary-desc-translations-should into master

Remove specfile translation review item

Otto Urpelainen • 2 years ago

f9a00bc

guidelines/modules/ROOT/pages/ReviewGuidelines.adoc

file modified

-1

		`@@ -49,7 +49,6 @@`
		`'''`

		`* SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. footnote:[xref:LicensingGuidelines.adoc#_license_text[Licensing Guidelines: License Text\]] +`
		`- * SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. footnote:[xref:index.adoc#_summary_and_description[Packaging Guidelines: Summary and description\]] +`
		`* SHOULD: The reviewer should test that the package builds in mock. footnote:[https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds[Using Mock to test package builds\]] +`
		`* SHOULD: The package should compile and build into binary rpms on all supported architectures. footnote:[xref:index.adoc#_architecture_support[Packaging Guidelines: Architecture Support\]] +`
		`* SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. +`

oturpe commented 2 years ago

The Review Guidelines item
about specfile description and summary translations
is not supported by anything in the Packaging Guidelines.
Given footnote only says that such translations can be included.
Since the Packaging Guidelines do not express any preference
for either including or omitting such translations,
there is not for the reviewer to check.

oturpe commented 2 years ago

Devel mailing list discussion: Specfile description and summary translations

tibbs commented 2 years ago

I've always thought that was kind of a weird rule. I know there used to be something called specspo which had external translations for packages, but I don't know if those were ever somehow sucked into the specfiles directly. If they were, that stopped before package maintenance was opened to the community back in the FC6 era.

I'm just going to merge this.

Pull-Request has been merged by tibbs

2 years ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+0 -1

file changed

guidelines/modules/ROOT/pages/ReviewGuidelines.adoc

		`@@ -49,7 +49,6 @@`
		`'''`

		`* SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. footnote:[xref:LicensingGuidelines.adoc#_license_text[Licensing Guidelines: License Text\]] +`
		`- * SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. footnote:[xref:index.adoc#_summary_and_description[Packaging Guidelines: Summary and description\]] +`
		`* SHOULD: The reviewer should test that the package builds in mock. footnote:[https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds[Using Mock to test package builds\]] +`
		`* SHOULD: The package should compile and build into binary rpms on all supported architectures. footnote:[xref:index.adoc#_architecture_support[Packaging Guidelines: Architecture Support\]] +`
		`* SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. +`

packaging-committee

Source Code

#1095 Remove specfile translation review item Merged 2 years ago by tibbs. Opened 2 years ago by oturpe. oturpe/packaging-committee remove-summary-desc-translations-should into master

Metadata

Changes Summary 1

#1095 Remove specfile translation review item

Merged 2 years ago by tibbs. Opened 2 years ago by oturpe.

oturpe/packaging-committee remove-summary-desc-translations-should into master