From 51efdd9a24275353cdb09b7e3fbcff6084af11a8 Mon Sep 17 00:00:00 2001 From: Otto Urpelainen Date: Jan 29 2021 15:03:46 +0000 Subject: Improve separate test suite sourcing instructions Instructions given for creating a source archive for test suites can be improved slightly. Existing method creates the archive from checked out Git branch. This leaves open the possibility that there are local changes in the working tree, which end up packaged. The proposed method avoids the possibility by never checking out anything and relying on 'git archive' that operates directly on committed items in the repository. --- diff --git a/guidelines/modules/ROOT/pages/Ruby.adoc b/guidelines/modules/ROOT/pages/Ruby.adoc index 4cd6bac..89e01d1 100644 --- a/guidelines/modules/ROOT/pages/Ruby.adoc +++ b/guidelines/modules/ROOT/pages/Ruby.adoc @@ -533,8 +533,7 @@ Sometimes you have to get the tests separately from upstream's gem package. As a .... # git clone https://github.com/bebanjo/delorean.git && cd delorean -# git checkout v1.2.0 -# tar -czf rubygem-delorean-1.2.0-specs.tgz spec/ +# git archive -o rubygem-delorean-1.2.0-specs.tgz v1.2.0 spec Source1: %{name}-%{version}-specs.tgz # ...