build-require -> BuildRequire

Us e a more specific example? E.g. %global py_reproducible_pyc_path %{buildroot}%{_datadir}/llamafarm/plugins -- a more specific example serves better because readers have a better idea how does the argument work.

In the guidelines, we usually focus less on the story ("we have created") and concentrate on the "hows" and "whats", e.g. say "To workaround this issue, BuildRequire marshalparser (a tool that makes pyc files more reproducible) and instruct it to process the pyc files in certain paths by setting the %py_reproducible_pyc_path macro".
Does that make sense?

The general message here is good, please consider to switch to https://sembr.org/ when you amend the changes. (If you don't want to, don't worry, somebody from the FPC will do that before the merge.)

Fixed. I wasn't sure about newlines because some parts of the document uses them and some not so I went with what's simpler for me.

Fixed.

Thanks!

I wasn't sure about newlines because some parts of the document uses them and some not so I went with what's simpler for me.

Only new or revisited parts of the text follow sembr.

With my FPC hat on: +1.

I wanted to push some AsciiDoc escape stuff in here, but Pagure doesn't let me, so I won't.

- `%{buildroot}%{_datadir}/llamafarm/plugins`
+ `+%{buildroot}%{_datadir}/llamafarm/plugins+`

etc...

+1

+1. I'm fine with the change/addition, but it feels like this just happen automatically when you build a python package.

but it feels like this just happen automatically when you build a python package.

This is only opt in for now, because the tool might not be able to parse everything yet. Also, it needs to be BuildRequired explicitly.

s/refference/reference/

LGTM otherwise.

and "is to blame here" sounds better than "is here to blame" :)

action Merge #pr-1013 Document py_reproducible_pyc_path macro (+1:5, 0:0, -1:0)

https://pagure.io/packaging-committee/c/4547e905ac5f502a60578dddb4549c946831d62c?branch=master