packaging-committee

#1010 Fix example for __provides_exclude_from
Merged by ignatenkobrain. Opened by jwakely.
jwakely/packaging-committee master  into  master

Download 1010.patch

The regex for this example was broken, using %{libdir} instead of %{_libdir} and splitting the ".*" string intended to match the filename.

Could we also do .*\\.so.*?

I initially thought we needed to use .*\\.so(\\..*)? to not match something like just.some.file

But I decided if the package puts something like that in %{_libdir} and wants it to be processed for auto-provides then the package is dumb. The packager can figure out how to adapt the example for their silly situation.

So I'll update the pull request ...

1 new commit added

  • Adjust example regex to match libfoo.so.1 as well

Now the regex looks like ^(foo.*|bar.*)$ which could just drop the end anchor and use ^(foo|bar) but I think explicitly using the $ anchor is useful for the purposes of the example.

Looks fine to me. Thanks.

rebased onto 3a35d8e5c834bb7f338b1bed1b06f312fc14b403

Pull-Request has been merged by ignatenkobrain
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.