#933 Invalid example in golang section
Closed: nothingtodo 2 years ago by tibbs. Opened 4 years ago by pbokoc.

I was cleaning up bugzilla and spotted this report (original bug: https://bugzilla.redhat.com/show_bug.cgi?id=1762730). I'm not sure if it's still relevant, feel free to close if it's already fixed.

====

Description of problem:
The documentation at https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ seems to provide an invalid example in its "Simple binary package" section. Following the example there results in a package specification that produces the following when processed with rpmbuild:

RPM build errors:
-u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!
Bad exit status from /tmp/rpm-tmp.rP7edU (%prep)

Indeed, the actual golang-github-boltdb-bolt package has diverged from the example at https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/.

Version-Release number of selected component (if applicable):
Webpage: Last build: Thu Oct 17 10:00:11 UTC 2019
Build host: Fedora 31

How reproducible:
Every time

Steps to Reproduce:
1. Write an RPM specification based on the "Simple binary package" example at https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
2. Run "rpmbuild -ba foo.spec"

Actual results:
-u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!

Expected results:
The package should build.


The warning is just like that, a warning.

You're hitting it because the review and integration of redhat-rpm-config macro changes, went faster than the review and integration of go macro changes, so redhat-rpm-config is complaining go macros are using a legacy syntax.

Later Fedora releases include the necessary Go macro updates.

I don't think this has been an issue for some time now.

I don't think this has been an issue for some time now.

Metadata Update from @tibbs:
- Issue close_status updated to: nothingtodo
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata