#893 Proposal: Cython sources must be regenerated
Opened a month ago by churchyard. Modified 13 days ago

Each time we update python to a new version, we fight packages that don't regenerate Cython sources.

I propose to require that Cython sources are regenerated in spec.

PR will follow.


Sounds good. I don't think there are any downsides to doing that, other than perhaps slightly longer build times?

More complicated bootstrap sequence maybe. Time should not matter, the increase is in seconds.

This seems fine to me (modulo some grammar fixes which I can comment on), but how do you know if you need to do this and how would a reviewer check that this is done properly?

Why would not we generalize this to all pre-generated sources?

Well, uh, maybe but we have historically stopped short of forcing regeneration of configure scripts or lex/yacc stuff. I'm not entirely sure we want to go down that road.

modulo some grammar fixes which I can comment on

Please do that in the PR.

how do you know if you need to do this

For any Python arch package, you should suspect this. and check. Grepping sources for "Generated by Cython" is a good way to check.

how would a reviewer check that this is done properly?

I guess by examining the sources and the logs. I can open a followup issue in FedoraReview for this.

Each time we update python to a new version, we fight packages that don't regenerate Cython sources.
I propose to require that Cython sources are regenerated in spec.
PR will follow.

Last time (3.8), the Cython version in Fedora was too old to handle the new Python. How would that alleviate this problem? Regenerating the Cython sources won't do much if Cython is not new enough.

I now maintain Cython in Fedora and do the 3.8 rebuilds. I carry temporary patches in the 3.8 Copr and am waiting for an upstream release. Will add the patches to Fedora if that won't happen soon enough.

On the other hand, we have at least ~20 packages that suffer from a Cython incompatibility with 3.8 that we have already fixed but the sources shipped are generated with an old version that doesn't contain the fix.

Of course, we can run Cython master on all the sources and carry a patch for each package, but that doesn't scale.

Metadata Update from @ignatenkobrain:
- Issue tagged with: meeting

20 days ago

From this weeks meeting: https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2019-06-06/fpc.2019-06-06-16.00.txt

  • #893 Proposal: Cython sources must be regenerated (geppetto,
    16:19:56)
  • ACTION: PR 894 (+1:6, 0:0, -1:0) (geppetto, 16:22:56)

Metadata Update from @james:
- Issue close_status updated to: accepted
- Issue status updated to: Closed (was: Open)

13 days ago

Metadata Update from @tibbs:
- Issue status updated to: Open (was: Closed)

13 days ago

Metadata Update from @tibbs:
- Issue untagged with: meeting
- Issue assigned to tibbs
- Issue tagged with: writeup

13 days ago

Login to comment on this ticket.

Metadata