#722 Advice on Provides for a fork of a fork bundled in package
Closed: fixed 6 years ago Opened 6 years ago by kevin.

python-html5-parser ( review: https://bugzilla.redhat.com/show_bug.cgi?id=1481046 ) bundles a fork of the gumbo-parser package (in fedora) called sigul-gumbo (not in fedora) and then modifies it.

Unbundling is pretty hopeless here as they have taken a snapshot of the fork and modified it.

In this case what should I add as a provides: ?

Nothing? (case is too complex and should be mentioned in spec only)

bundled(sigul-gumbo) ? (This might help someone who someday packages that or wants to look for bundled cases of it, but it's really a fork of that too).

bundled(gumbo-parser) ? (it's not really true, it's a modified fork of a fork)

bundled(gumbo-parser-static) ? (since it's a staticly linked version of a fork of a fork)

something else?

Thanks for any advice...


I'd add both.
Provides: bundled(sigul-gumbo) = version at snapshot point
and
Provides: bundled(gumbo-parser) = version at fork point
Using -static is technically correct, but I wouldn't use it as it makes things unnecessarily complex.

ok, that makes sense to me. Here's what I am going to put in the spec and see if my reviewer is happy:

This package bundles sigil-gumbo a fork of gumbo

Base project: https://github.com/google/gumbo-parser

Forked from above: https://github.com/Sigil-Ebook/sigil-gumbo

It also patches that bundled copy with other changes.

sigul-gumbo bundled here was added 20170601

Provides: bundled(sigil-gumbo) = 0.9.3-20170601git0830e1145fe08

sigul-gumbo forked off grumbo-parser at this commit in 20160216

Provides: bundled(gumbo-parser) = 0.9.3-20160216git69b580ab4de04

Thanks.

Did this work out OK?

yep, seems to have... this can be closed as far as I am concerned.

Metadata Update from @kevin:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata