#706 Must LDFLAGS honor %{__global_ldflags}?
Closed: duplicate 5 years ago Opened 6 years ago by musuruan.

Guideline page needing clarification:

Current Packaging Guidelines only mentions %optflags:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags

Explanation

During a package review, the reviewer told me LDFLAGS must honor %{__global_ldflags}:
https://bugzilla.redhat.com/show_bug.cgi?id=1468830#c7

It seemed sensible to me and I also found out this old thread that seems to support this requirement:
https://www.spinics.net/lists/fedora-devel/msg190123.html

Can you please clarify and eventually amend the Packaging Guidelines?

Thanks,

Andrea


We could change the section to Compiler and Linker flags and then add mention of %__global_ldflags. Though, really, we should think about the future a bit more, to a day when maybe some things compile with a different C compiler. Will it need different flags, or even accept the same flags as gcc? Will we ever use a different linker? (I recall some attempts to use gold at one point.)

Of course, we could also just state that things apply only to gcc and binutils.

I'll whip up a couple of alternative drafts.

Metadata Update from @tibbs:
- Issue assigned to tibbs
- Issue tagged with: committee

6 years ago

@tibbs talking about different flags for different compilers/linkers.. We've touched this topic in https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/1 somehow.

@tibbs I would close this as duplicate of #743 (even though it's much newer). Any objections?

Metadata Update from @ignatenkobrain:
- Issue close_status updated to: duplicate
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata