https://fedoraproject.org/w/index.php?title=User:Zbyszek/SourceDraft&oldid=497875
https://fedoraproject.org/w/index.php?title=User%3AZbyszek%2FSourceDraft&diff=497875&oldid=497868
Github now allows nicer syntax for tarballs generated from commit hash. It's a bit shorter and clearer and easier to copy&paste (no shell special characters).
Also fix some typos and change %commit0 to %commit (great majority of spec files have just one tarball, so let's simplify the common case).
Metadata Update from @tibbs: - Issue tagged with: meeting
It's nice that github changed this. It's a bit confusing to have that change mixed in with the other changes you made, though.
To be clear, the functional change here is going from this:
Source0: https://gitlab.com/OWNER/%{name}/repository/archive.tar.gz?ref=%{commit0}#/%{name}-%{shortcommit0}.tar.gz
to
Source0: https://github.com/OWNER/%{name}/archive/%{commit0}/%{name}-%{shortcommit0}.tar.gz
The rest of the draft is changing %commit0, %shortcommit0 and %gittag0 to %commit, %shortcommit and %gittag. Personally I'm a fan.
Unfortunately the draft is not consistent about the treatment of Source0:/Source:. That change is made in one place near the bottom but not anywhere else in the document. I don't have much problem with just using Source: when you have only one, but it's easy for a beginner to be confused by the fact that Source: means Source0:, not Source1:.
You are right that my changes were inconsistent. I fixed the text to refer to Source0 everywhere.
So the summary of changes now is: - update github URL syntax, - replace %commit0 with %commit, and similarly for %shortcommit0, %gittag0, - correct a few minor typos and formatting issues
revision: https://fedoraproject.org/w/index.php?title=User:Zbyszek/SourceDraft&oldid=499002 diff: https://fedoraproject.org/w/index.php?title=User%3AZbyszek%2FSourceDraft&diff=499002&oldid=497868
Pretty happy with this draft, +1
We discussed this at this weeks meeting (https://meetbot-raw.fedoraproject.org/fedora-meeting-2/2017-08-09/fpc.2017-08-09-17.00.txt):
Metadata Update from @james: - Issue untagged with: meeting - Issue assigned to tibbs - Issue tagged with: writeup
Metadata Update from @mbooth: - Issue untagged with: writeup - Issue tagged with: announce
Announcement text:
Use the simplified form of github URLs in the source URL guidelines.
Metadata Update from @tibbs: - Issue untagged with: announce - Issue close_status updated to: accepted - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.