#651 Guidelines should suggest downloading source from Github in correct format instead of renaming it
Closed: Fixed None Opened 2 years ago by pidgornyy.

Currently the guidelines ([https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags]) suggest that the best way of downloading source from Github in the correct format is to download it in the wrong format, then manually rename it (e.g. with spectool):

Source0: https://github.com/OWNER/%{name}/archive/GIT-TAG.tar.gz#/%{name}-%{version}.tar.gz

However, it is much smarter to download the archive in the correct format straight away. If Github provides the file in the correct format, why download it wrongly and manually rename it?

Source0: https://github.com/OWNER/%{name}/archive/GIT-TAG/%{name}-%{version}.tar.gz

(GIT-TAG often being either %{version} or v%{version})

We should update the wiki to reflect this, otherwise new packagers learn the "wrong" way.

Github keeps changing what they support. At the time that document was written, use of the '#' trick was required. If it's not, that's great. Can someone confirm that this is something github intends to actually keep in the future?

We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2016-10-06/fpc.2016-10-06-16.00.txt):

  • 651 Guidelines for new Github source format (geppetto, 16:29:37)

  • ACTION: Guidelines for new Github source format (+1:6, 0:1, -1:0)
    (geppetto, 16:35:13)

Who is going to do the writeup? I don't seem to have write permissions on the respective wiki page.

That would be me, when I get the chance.

Only FPC members have permissions to write to wiki pages in the Packaging: namespace.

I finally found the time to do this. I was leaning towards it not being worth an announcement, but then realized that just like everyone on the FPC, packagers might not realize that Github has begun to support a simpler download URL. So, announcement text:

The SourceURL guidelines were updated to reflect a simpler method for downloading tagged releases from Github.

Metadata Update from @pidgornyy:
- Issue assigned to tibbs

2 years ago

Login to comment on this ticket.