#632 Requires: hicolor-icon-theme or own %{_datadir}/icons/hicolor
Closed: accepted 2 years ago Opened 3 years ago by vascom.

Should I specify in spec-file

Requires: hicolor-icon-theme

or make package owner of directory %{_datadir}/icons/hicolor if my package put icons here?

Please correct this instruction https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
with answer to my question.


In my opinon, easier/safer to just add
Requires: hicolor-icon-theme

(if nothing else in your stack of dependencies pulls it in)

Guidelines are not clean here, so let's reopen it for some volunteer to propose guidelines change.

I'm trying to understand the issue here. The referenced guideline relates to whether a package should own a directory and has no relation to dependencies, so it's not where you would go to find an answer to the question which is posed.

The relevant guideline, I think, is https://fedoraproject.org/wiki/Packaging:Guidelines#Package_dependencies and after reading it I think it could use some work in general. It does seem covers all of the cases explicitly except the case of directory dependencies.

I would lean towards just changing "File Dependencies" to "File and Directory Dependencies" and updating the text of that section to reference "files and directories" as appropriate.

Metadata Update from @tibbs:
- Issue close_status updated to: None
- Issue tagged with: meeting

2 years ago

Metadata Update from @tibbs:
- Issue tagged with: hasdraft

2 years ago

We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2017-02-23/fpc.2017-02-23-17.00.txt):

  • 632 Requires: hicolor-icon-theme or own dir (geppetto, 18:01:15)
  • ACTION: Directory deps. wording added/updated. (+1:6, 0:0, -1:0)
    (geppetto, 18:19:08)

Metadata Update from @james:
- Issue untagged with: hasdraft, meeting
- Issue tagged with: writeup

2 years ago

Metadata Update from @james:
- Issue assigned to tibbs

2 years ago

Written up. Announcement text:

The main guidelines section on file dependencies was amended to include information about directory dependencies, including a rule against depending on a directory in order to bring in any files or package functionality.

Metadata Update from @tibbs:
- Issue untagged with: writeup
- Issue tagged with: announce

2 years ago

Metadata Update from @tibbs:
- Issue untagged with: announce
- Issue close_status updated to: accepted
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata