Hello FPC members,
I would like to discuss one thing with you. In the Packaging Guidelines written following:
It is not simply enough to just include the .desktop file in the package, one MUST run desktop-file-install (in %install) OR desktop-file-validate (in %check or %install) and have BuildRequires: desktop-file-utils, to help ensure .desktop file safety and spec-compliance.
And for some contributors it is not very clean about BuildRequires. I'm pretty sure that if I use desktop-file-validate in %check section I can specify BuildRequires: /usr/bin/desktop-file-validate and it will be perfectly fine and doesn't violate guideliness.
Would be great to clarify it.
The discussion came out of this bug:
It could just be a language issue but the guidelines do appear to state a MUST on that statement "and have BuildRequires: desktop-file-utils" bit ...
I agree clarifying what BR MUST be in place (as opposed to say MUST BR the selected tool) in the guidelines would be useful.
Both are correct. Either BR: desktop-file-utils and: BR: /usr/bin/desktop-file-validate (or -install, or both).
This seems like a minor wording change to clarify what is needed. Do you have any suggestions?
We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2016-06-23/fpc.2016-06-23-16.00.txt):
Metadata Update from @james:
- Issue assigned to james
I'm going to go ahead and close it. And since I've just been in the guideline regarding file dependencies, I don't really see how it fails to cover exactly this case anyway.
Metadata Update from @tibbs:
- Issue close_status updated to: nothingtodo
- Issue status updated to: Closed (was: Open)
to comment on this ticket.