#590 systemd links update
Closed: Fixed None Opened 3 years ago by zbyszek.

Systemd upstream has moved to github, and the guidelines for starting services have been merged into core packaging guidelines. Triggers are spread between two file after addition of transfiletriggers. Obsolete links in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd:

Fedora preset policy [https://fedoraproject.org/wiki/Starting_services_by_default]

[Packaging:DefaultServices].

http://cgit.freedesktop.org/systemd/systemd/tree/src/core/macros.systemd.in

https://github.com/systemd/systemd/blob/master/src/core/macros.systemd.in
and
https://github.com/systemd/systemd/blob/master/src/core/triggers.systemd.in.


Do you have an example policy patch in mind?

No, but I can write one if that would help.

It makes it much easier on us if we have something to just vote yes on, rather than having to try to come up with changes and worry if they are correct/enough/etc.

We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2016-01-21/fpc.2016-01-21-17.00.txt):

  • 590 systemd links update (geppetto, 17:04:40)

  • ACTION: systemd minor policy update and github URL change (+1:8,
    0:0, -1:0) (geppetto, 17:20:31)

While writing this up (finally) something occurred to me. The guideline includes the following:

Note that the %systemd_requires macro must not be used.

If it's really not to be used, why does the systemd package even define that macro? Why not just define it to

%{error:The systemd_requires macro must not be used.}

and drop that bit from the guidelines entirely?

Announcement text:

The systemd scriptlet guidelines were cleaned up to use correct links and fix some typos.

If it's really not to be used, why does the systemd package even define that macro?

It's defined upstream.

Maybe we could finally allow it to be used? It'd reduce the amount of boilerplate somewhat, and also allow more flexibility (we could reduce the number of Requires now that file triggers are being used).

We can override macros (just make sure the macro file which contains the override sorts alphabetically after the one you want to override). So if we wanted to do so, we could.

I've opened https://fedorahosted.org/fpc/ticket/600 to discuss this.

Metadata Update from @zbyszek:
- Issue assigned to tibbs

2 years ago

Login to comment on this ticket.

Metadata