#583 Node.js Guideline Addition
Closed: Fixed None Opened 3 years ago by sgallagh.

Please add the following text to https://fedoraproject.org/wiki/Packaging:Node.js :

All Node.js module spec files must include a %check section that contains (at minimum) the line:
{{{
%{__nodejs} -e 'require("./")'
}}}
This test ensures that the module is actually loadable, which will help avoid situations where a new upstream release has added a new dependency without the packager noticing.

Any other tests made available by upstream should also be run wherever possible.


We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2015-12-17/fpc.2015-12-17-17.00.txt):

  • 583 Node.js Guideline Addition (geppetto, 17:21:07)

  • LINK: https://fedorahosted.org/fpc/ticket/583 (geppetto, 17:21:19)
  • ACTION: Node.js Guideline Addition, to do loads in %check (+1:7,
    0:0, -1:0) (geppetto, 17:30:42)

Announcement text:

The node.js guidelines have gained a requirement for a %check section which at minimam ensures that the module is loadable.
https://fedoraproject.org/wiki/Packaging:Node.js#Build_testing_in_.25check
https://fedorahosted.org/fpc/ticket/583

Metadata Update from @james:
- Issue assigned to tibbs

2 years ago

Login to comment on this ticket.

Metadata