#538 Bundling exception for htmlunit-core-js
Closed: Fixed None Opened 4 years ago by gil.

Hi,
I would like to request permission to bundle forked code from Rhino [1] in htmlunit-core-js package .

[1] https://github.com/mozilla/rhino
[2] https://admin.fedoraproject.org/pkgdb/package/htmlunit-core-js/

htmlunit-core-js contains files forked from mozilla rhino 1.7.7 (in Fedora available 1_7R4). This files is included in htmlunit-core-js source repository [3] and maintained as part of the project. Since the files was forked, htmlunit-core-js upstream implemented a few features.

[3] https://github.com/HtmlUnit/htmlunit-rhino-fork

thanks in advance


We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2015-06-04/fpc.2015-06-04-16.02.txt):

The main discussion was that the bundling seems big, and none of the standard FPC bundling questions were answered. See:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions

Replying to [comment:2 james]:

We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2015-06-04/fpc.2015-06-04-16.02.txt):

The main discussion was that the bundling seems big, and none of the standard FPC bundling questions were answered. See:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions

hi
seem you have posted the wrong symlinks of core-js.
the correct one is https://github.com/HtmlUnit/htmlunit-rhino-fork/
my apologies, but I seem to have been quite comprehensive, as regards the reasons for the request.
1. our rhino package is too old
2. htmlunit use a customization release of rhino (see rhinoDiff.txt), without this don't build/work
for me is all here.
to you the decision whether to continue to maintain htmlunit, or withdraw from distribution.
thanks in advance

We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2015-06-25/fpc.2015-06-25-16.01.txt):

  • 538 Bundling exception for htmlunit-core-js (geppetto, 17:21:11)

  • LINK: https://fedorahosted.org/fpc/ticket/538 (geppetto, 17:21:12)
  • ACTION: Bundling exception for htmlunit-core-js (+1:0, 0:0, -1:4)
    (geppetto, 17:34:41)
  • ACTION: Work with the rhino package in Fedora to get it updated.
    (geppetto, 17:34:51)
  • ACTION: Answer the questions in the bundling exception process about
    why you can't merge the diffs. into upstream rhino. (geppetto,
    17:35:15)
  • rhino is really big, actively maintained and security sensitive. At
    best you'll get permission to ship a forked copy. (geppetto,
    17:37:06)

Just for the record, I filed https://bugzilla.redhat.com/show_bug.cgi?id=1235782 to see if Rhino can be updated.

I don't think it will solve the issue here but it would at least solve the "our rhino package is too old" problem. I'm not sure why a bug wasn't filed before if the old package was a problem.

As FPC is no longer in the business of approving or disapproving bundling requests outside of the critical path, there's nothing left to do here. Please be sure to add Provides: bundled(rhino) to your package.

Metadata Update from @tibbs:
- Issue assigned to tibbs

2 years ago

Login to comment on this ticket.

Metadata