#48 Drop redundant VERBOSE=1 from CMake guideline
Closed: Fixed None Opened 13 years ago by kkofler.

The "Specfile Usage" snippet under https://fedoraproject.org/wiki/Packaging/cmake contains VERBOSE=1. This is not needed anymore (and hasn't been for a while), because we already set -DCMAKE_VERBOSE_MAKEFILE=ON in the %cmake and %cmake_kde4 macros. Therefore I propose to remove the redundant VERBOSE=1, changing the relevant line to just:
{{{
make %{?_smp_mflags}
}}}


Can't argue with this. If the option doesn't do anything, there's no point in having it there.

While we're in that document, could you also check that the RPM Macros section is accurate? Or, better yet, can we just remove it, or replace it with a mention of the location of the actual macros in case folks wish to look? It seems pointless to have a potentially outdated copy of macros that can easily be viewed directly.

Agreed, I'll take a stab at updating this accordingly, to mention both macros.cmake and macros.kde4, and give usage examples for both.

Arg, looks like I actually did edits to address this on Jan 24, then summarily forgot about it (and failed to update this ticket).

Metadata Update from @rdieter:
- Issue assigned to rdieter

7 years ago

Login to comment on this ticket.

Metadata