#454 Bundling exception for php-phpoffice-phpexcel
Closed: Fixed None Opened 4 years ago by siwinski.

From review request discussion, I would like a bundling exception for PHPExcel's OLE because it is more of a fork than a bundle library.

Review request: https://bugzilla.redhat.com/show_bug.cgi?id=1102942

PHPExcel's OLE:
https://github.com/PHPOffice/PHPExcel/tree/develop/Classes/PHPExcel/Shared/OLE.php
https://github.com/PHPOffice/PHPExcel/tree/develop/Classes/PHPExcel/Shared/OLE

PEAR's OLE:
* http://pear.php.net/package/OLE

PHPExcel's explanation of not using PEAR's OLE: https://github.com/PHPOffice/PHPExcel/issues/407#issuecomment-49647361


This didn't get passed, but it might with some more info. about why you can't work with what upstream there is (or become it). A few things:

  1. From the upstream response that "It was originally bundled with PHPExcel for the benefit of people who couldn't/wouldn't install dependencies manually" ... this doesn't affect Fedora.

  2. The fact there there hasn't been much upstream development is a plus, but doesn't mean you just get to bundle it ... you are allowed to take over maintainership too.

  3. The fact execl OLE doesn't have the 2 year old bugfixes from the last release of pear OLE does not encourage us.

  4. You can get around the exception problem by just having a set of APIs which call the pear OLE code, catch their exceptions and rethrow as your exceptions.

  5. Fedora has shipped pear OLE for years now ... I'd be tempted to allow bundling on the assumption it was dead, if we weren't shipping it.

  6. As the final comment on github/PHPOffice says ... there is a github upstream for pear OLE, have you tried contacting them (and/or offering help/pull-requests?)

The packaging committee is still awaiting additional information before it can properly address your request. Please provide that within the next month or this ticket will be closed. (Of course, you can always reopen it if the situation changes) Thanks!

No response; closing. Feel free to reopen if you have more information to add.

Login to comment on this ticket.

Metadata