#39 New library bundling exception: shedskin
Closed: Fixed None Opened 13 years ago by tomspur.

The review request of shedskin is at:
https://bugzilla.redhat.com/show_bug.cgi?id=554187

Shedskin had a licensing problem with the implemented hash function. Now upstream used [http://sites.google.com/site/murmurhash/ murmur] which is only a copy of 60 lines of code (~20 lines of comments).

  • Furthermore shedskin searched for 'a' fast hash function and that's it. So it's likely that it will change, if there is another (maybe better) hash function out there.

  • Shedskin isn't forking it's just copying one single function, so it's easier to work on all platforms.

  • The changes made to that function, were only to implement it into shedskin and is not usefull to anyone else.

  • Don't know if upstream will reqularily update the function to a newer version, maybe to another function, which has nothing to do with murmur at all...

  • There is no plan of unbundling, if there is another better hash out there, upstream will move on, untill then, this function will stay as it is.

Can I get an exception to 'bundle' this function?
I don't even know, if this is a real 'bundling' because this function is deeply implemented into shedskin and not used with '#include <foo>' and adding the header to shedskin (which is what I expect as a definition of 'bundling').

Maybe that's another topic the FPC should discuss (Definition of a bundled library, e.g. added as header files with more than 50 lines)?


I think this is a pretty obvious candidate for an exception. I guess it blurs the line between "library" and "small code snippet you copy off a web page", but it does have a real upstream, license, release schedule, etc. and rather than trying to carve out some sort of general exception it seems simpler to just handle it specifically.

Exception granted. Package must document the murmurhash bundling, have appropriate bundled Provide, and if murmurhash ever is packaged as a standalone library in Fedora, this package must then use it. (+1:6, 0:0, -1:0)

shedskin package has merged changes, closing out.

Metadata Update from @spot:
- Issue assigned to spot

7 years ago

Login to comment on this ticket.

Metadata