#308 Please deprecate usage of systemd-sysv-convert in the packaging policy for F20
Closed: Fixed None Opened 6 years ago by lennart.

Since we adopted systemd in F15 the packaging policy recommended usage of the systemd-sysv-convert tool from the rpm scriptlets, which I wrote on request of FPC.

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

I'd like to drop this tool from F20 on because I am pretty sure no user ever made any use of this. My proof is twofold. I started this thread on fedora-devel a few days ago:

https://lists.fedoraproject.org/pipermail/devel/2013-June/184271.html

in there I clarified that I wanted to get rid of this thing, and asked around if anybody would mind. And, well, nobody did. (well Jon Ciesla did, but I think he misunderstood what the tool does, i.e. it's not a converter for init scripts to systemd units, but much rather something that just stores runlevel information when we drop sysv scripts and adopt systemd units.)

And also, I never got any bug reports about it, even though the tool is awful, since mapping runlevels to targets can't really work. People using it must have noticed that and complained...

So, yeah, I'd like to get rid of this. Carrying this for 5 years should be enough. I am fully aware that there are still many packages with sysv scripts in the archive, but I seriously doubt anybody would use that now, given that nobody used it for the past 2.5 years...

So, I'd like to ask FPC to remove the section form the packaging guidelines. When that's done I will stop shipping the tool in question and make systemd itself provide systemd-sysv. Since the invocations of the tool are suffixed with "2>&1 > /dev/null || :" the invocations will become nops, and that'd be the end of the story.


To be honest I've never been particularly fond of this. If everything "system critical" has been converted and all we have left is either leaf node packages or things which probably won't ever convert for whatever reason, I'd be happy with the simplification that would come from getting rid the conversion stuff. But then the question remains as to what actually gets changed. Can the entire "Packages migrating to a systemd unit file from a SysV initscript" section go? I guess the admon about not converting during a release needs to stick around somewhere, but I'm not sure about the other stuff.

Replying to [comment:1 tibbs]:

To be honest I've never been particularly fond of this. If everything "system critical"

network is a holdout. And I figure it's not going to be change really until NM takes over...

has been converted and all we have left is either leaf node packages or things which probably won't ever convert for whatever reason, I'd be happy with the simplification that would come from getting rid the conversion stuff. But then the question remains as to what actually gets changed. Can the entire "Packages migrating to a systemd unit file from a SysV initscript" section go? I guess the admon about not converting during a release needs to stick around somewhere, but I'm not sure about the other stuff.

Yeah, I'd suggest removing the whole section. The admon should stay, indeed.

info Drop use of systemd-sysv-convert from the guidelines Approved (+1:5, 0:0, -1:0)

Here's the draft that was approved:

https://fedoraproject.org/wiki/User:Toshio/Systemd_Convert_draft

In addition, we noted that removing the package systemd-sysv itself will cause package installation failures (because they Require(post): systemd-sysv). Please coordinate this aspect through the F20 Changes process before removing the package.

Guidelines have been modifed: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Packages_migrating_to_a_systemd_unit_file_from_a_SysV_initscript

Announcement writeup:

"""
The trigger scripts that saved information about sysv runlevels when converting to systemd have been dropped on the basis that everything of importance has been converted and the system for saving that information was always kludgy and complex. Packages that are converting now should not include them. Lennart will submit a Changes Proposal to coordinate updating packages that presently have these trigger scripts in order to remove the actual systemd-sysv package.
"""

Login to comment on this ticket.

Metadata