#1 Version._to_fedora produces odd versions
Closed: Fixed 3 years ago by jjames. Opened 3 years ago by defolos.

I have started implementing tests for opam2rpm and stumbled over version.py:157. The last branch appears odd to me, especially the join() call. E.g. Version("b1.2").to_fedora() will result in the second tuple parameter being 0.1.b0.1.1.0.1.2 (if my brain produced this correctly).

This pathological example aside, shouldn't the join be a string concatenation instead?


Sorry for the delay, Dan, and thanks for writings tests. You're right. I think I see what to do. Fix hopefully coming right up.

Login to comment on this ticket.

Metadata