From 87e9a63f922cc8926011de9337c79b91f3e1be4c Mon Sep 17 00:00:00 2001 From: Jerry James Date: Apr 19 2021 20:24:12 +0000 Subject: But do not modify the version objects in place! --- diff --git a/opam2rpm/version.py b/opam2rpm/version.py index 2f48e92..4d997af 100644 --- a/opam2rpm/version.py +++ b/opam2rpm/version.py @@ -96,11 +96,13 @@ def add_zeroes(elems1: List[str], elems2: List[str]) -> List[Tuple[str, str]]: element pairs, pretend the other has dot-zero pairs to match. This is necessary for tilde comparisons to work on versions of differing length. """ - while len(elems1) + 1 < len(elems2) and elems2[len(elems1)] == '.': - elems1 += ['.', '0'] - while len(elems2) + 1 < len(elems1) and elems1[len(elems2)] == '.': - elems2 += ['.', '0'] - return zip_longest(elems1, elems2) + e1 = list(elems1) + e2 = list(elems2) + while len(e1) + 1 < len(e2) and e2[len(e1)] == '.': + e1 += ['.', '0'] + while len(e2) + 1 < len(e1) and e1[len(e2)] == '.': + e2 += ['.', '0'] + return zip_longest(e1, e2) @final class Version: