PR#438: Copy raw config wrapper without permissions - odcs

odcs

#438 Copy raw config wrapper without permissions

Merged 3 years ago by lsedlar. Opened 3 years ago by lsedlar.

lsedlar/odcs fix-config-perms into master

Copy raw config wrapper without permissions

Lubomír Sedlář • 3 years ago

44cc226

server/odcs/server/pungi.py

file modified

+1 -1

		`@@ -117,7 +117,7 @@`
		`# and override some variables.`
		`if self.raw_config_wrapper_conf_path:`
		`main_cfg_path = os.path.join(topdir, "raw_config.conf")`
		`- shutil.copy2(`
		`+ shutil.copyfile(`
		`self.raw_config_wrapper_conf_path, os.path.join(topdir, "pungi.conf")`
		`)`
		`self.apply_raw_config_wrapper_overrides(os.path.join(topdir, "pungi.conf"))`

lsedlar commented 3 years ago

The wrapper in /etc/odcs is quite possibly a read-only file. If we copy it with permissions, we end up with a file that can not be modified. Since we do intend to modify it, only the contents should be copied.