From d97db45afe46726ba0f5b2717594edc3dc6b6f0d Mon Sep 17 00:00:00 2001 From: Jan Kaluza Date: Jan 31 2019 10:22:35 +0000 Subject: Fix issue when check_deps is not bool but int which breaks Pungi. --- diff --git a/server/odcs/server/pungi.py b/server/odcs/server/pungi.py index 0ae356f..7840c1c 100644 --- a/server/odcs/server/pungi.py +++ b/server/odcs/server/pungi.py @@ -168,7 +168,7 @@ class PungiConfig(BasePungiConfig): else: raise ValueError("Unknown source_type %r" % source_type) - self.check_deps = flags & COMPOSE_FLAGS["check_deps"] + self.check_deps = bool(flags & COMPOSE_FLAGS["check_deps"]) @property def source_type_str(self): diff --git a/server/tests/test_pungi.py b/server/tests/test_pungi.py index d612235..92cd954 100644 --- a/server/tests/test_pungi.py +++ b/server/tests/test_pungi.py @@ -168,13 +168,13 @@ class TestPungiConfig(unittest.TestCase): template = pungi_cfg.get_pungi_config() cfg = self._load_pungi_cfg(template) - self.assertFalse(cfg["check_deps"]) + self.assertIs(cfg["check_deps"], False) pungi_cfg = PungiConfig("MBS-512", "1", PungiSourceType.KOJI_TAG, "f26", flags=COMPOSE_FLAGS["check_deps"]) template = pungi_cfg.get_pungi_config() cfg = self._load_pungi_cfg(template) - self.assertTrue(cfg["check_deps"]) + self.assertIs(cfg["check_deps"], True) def test_get_pungi_conf_multilib(self): _, mock_path = tempfile.mkstemp()