#252 Do not require sytem site libs for testing
Merged 3 months ago by jkaluza. Opened 3 months ago by lucarval.
lucarval/odcs isloated-tox-env  into  master

file modified
+8 -3

@@ -143,8 +143,8 @@ 

  - `multilib_arches` - Subset of `arches` for which the multilib should be enabled. For each architecture in the `multilib_arches` list, ODCS will include also packages from other compatible architectures in a compose. For example when "x86_64" is included `multilib_arches`, ODCS will include also "i686" packages in a compose. The set of packages included in a composes is influenced by `multilib_method` list.

  - `multilib_method` - List defining the method used to determine whether consider package as multilib. Defaults to empty list. The list can have following values:

      - `iso` - Generates non-installable ISO files with RPMs from a compose.

-     - `runtime` - Packages whose name ends with "-devel" or "-static" suffix will be considered as multilib. 

-     - `devel` - Packages that install some shared object file "*.so.*" will be considered as multilib. 

+     - `runtime` - Packages whose name ends with "-devel" or "-static" suffix will be considered as multilib.

+     - `devel` - Packages that install some shared object file "*.so.*" will be considered as multilib.

      - `all` - All pakages will be considered as multilib.

  - `builds` - List of NVRs defining the Koji builds to include in a compose. Only valid for `tag` and `build` source types. For `tag` source type, the NVRs will be considered

  for inclusion in a compose on top of Koji tag defined by `source`. For `build` source type, only the Koji builds defined by the NVRs will be considered for inclusion. The `packages` still need to be set to include particular packages from the Koji builds in a compose.

@@ -231,9 +231,14 @@ 

  Install packages required by pip to compile some python packages:

  

  ```

- $ sudo yum install -y gcc swig redhat-rpm-config python-devel openssl-devel openldap-devel

+ $ sudo dnf install -y gcc swig redhat-rpm-config python-devel openssl-devel openldap-devel \

+     zlib-devel bzip2 bzip2-devel readline-devel sqlite sqlite-devel tk-devel \

+     git python3-cairo-devel cairo-gobject-devel gobject-introspection-devel

  ```

  

+ A lot of these dependencies come from the module

+ [pygobject](https://pygobject.readthedocs.io/en/latest/devguide/dev_environ.html#fedora-dep).

+ 

  Koji is required but not available on pypi.python.org, we enabled system sitepackages for tox, so koji can be found while running tests.

  

  ```

file modified
+2

@@ -23,3 +23,5 @@ 

  pyldap

  defusedxml

  productmd

+ pygobject

+ koji

file modified
-2

@@ -7,8 +7,6 @@ 

  envlist = py27, py3, flake8, bandit

  

  [testenv]

- # using sitepackages is not a good idea, but Koji... :(

- sitepackages = True

  install_command = pip install --force-reinstall --ignore-installed {packages}

  deps =

      -r{toxinidir}/test-requirements.txt

Trim trailing white spaces in README.md
Do not require sytem site libs for testing

The Koji library is now available in pypi. Let's use that!
Also, added missing requirement on pygobject library and additional
instructions for running unit testing.

Thanks, merging :wine_glass: .

Pull-Request has been merged by jkaluza

3 months ago