PR#239: Fix F901 errors and disable W504 checks - odcs

odcs

#239 Fix F901 errors and disable W504 checks

Merged 5 years ago by jkaluza. Opened 5 years ago by lucarval.

lucarval/odcs fix-flake8-errors into master

Fix F901 errors and disable W504 checks

Luiz Carvalho • 5 years ago

f874eb3

server/odcs/server/backend.py

file modified

+1 -1

		`@@ -73,7 +73,7 @@`
		`Reimplement this method in your own BackendThread subclass.`
		This method is called every `timeout` seconds.
		`"""`
		`- raise NotImplemented("do_work() method not implemented")`
		`+ raise NotImplementedError("do_work() method not implemented")`

		`def _run(self):`
		`"""`

tox.ini

file modified

+1 -1

		`@@ -32,7 +32,7 @@`
		`basepython = python3`
		`skip_install = true`
		`deps = flake8`
		`- commands = flake8 --ignore E501,E731 --exclude server/odcs/server/migrations/,.tox/,build/*,.env`
		`+ commands = flake8 --ignore E501,E731,W504 --exclude server/odcs/server/migrations/,.tox/,build/*,.env`

		`[testenv:bandit]`
		`basepython = python3`

lucarval commented 5 years ago

The following error is fixed:
F901 'raise NotImplemented' should be 'raise NotImplementedError'

The following error is now ignored:
W504 line break after binary operator

It is ignored because moving the line break to before the binary operator
causes W503 error (line break before binary operator). With this change
we get closer to consistency throughout the project.

Signed-off-by: Luiz Carvalho lucarval@redhat.com