PR#112: Fix unlink compose directory - odcs

odcs

#112 Fix unlink compose directory

Closed 6 years ago by cqi. Opened 6 years ago by cqi.

cqi/odcs fix-unlink-compose-directory into master

Fix unlink compose directory

Chenxiong Qi • 6 years ago

39f8988

server/odcs/server/backend.py

file modified

-1

		`@@ -119,7 +119,6 @@`
		`"""`
		`if os.path.realpath(toplevel_dir) != toplevel_dir:`
		`targetpath = os.path.realpath(toplevel_dir)`
		`- os.unlink(toplevel_dir)`
		`shutil.rmtree(targetpath)`

		`def do_work(self):`

cqi commented 6 years ago

Signed-off-by: Chenxiong Qi cqi@redhat.com

Found this when run test TestExpireThread.test_expire_done.

jkaluza commented 6 years ago

Can you describe more why this is removed? I think this is here to remove symlink from "latest-odcs-N" to the "odcs-N.N" directory.

cqi commented 6 years ago

Can you describe more why this is removed? I think this is here to remove symlink from "latest-odcs-N" to the "odcs-N.N" directory.

            targetpath = os.path.realpath(toplevel_dir)
            import pytest; pytest.set_trace()
>           os.unlink(toplevel_dir)
E           OSError: [Errno 21] Is a directory: './latest-odcs-1-1'

It is a directory in my machine.

jkaluza commented 6 years ago

Hm, is that hardlink? I think it really has to point to that other directory somehow.

cqi commented 6 years ago

Wired. It does not happen now. I'm going to close this pr.

Pull-Request has been closed by cqi

6 years ago