#392 "odcs get" returns "latest" symlinks for failed composes
Closed 3 years ago by lsedlar. Opened 3 years ago by ktdreyer.

I attempted a compose with ODCS and it (rightly) failed due to missing GPG signatures. When I query the compose with odcs --redhat get ..., the "result_repo" and "result_repofile" entries link to the "latest" symlinks:

$ odcs --redhat get 364700
...
    "result_repo": "http://odcs.engineering.redhat.com/composes/latest-odcs-364700-1/compose/Temporary",
    "result_repofile": "http://odcs.engineering.redhat.com/composes/latest-odcs-364700-1/compose/Temporary/odcs-364700.repo",

The "latest-odcs-364700-1" symlink does not exist on the server. Pungi does not create these symlinks because the compose did not complete, so these two URLs are HTTP 404 errors.

If Pungi never successfully completed a compose, we should not return broken links. The correct links should use the full compose ID instead of the "latest" symlinks, eg. "http://odcs.engineering.redhat.com/composes/odcs-364700-1-20200519.n.0"


This is already fixed in latest version, which is not yet deployed internally in Red Hat. That version uses odcs-$id in URL and no symlinks are involved anymore.

Metadata Update from @lsedlar:
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata