#68 defect, missing event registration for signals
Closed: Fixed None Opened 7 years ago by firstyear.

In my clean up, apparently I broke signal registration.

Re-add signal registration, and add a test to ensure we aren't missing it again.


Could you please remove a trailing white space of NS_JOB_PERSIST? :)
{{{
465 ns_add_signal_job(ctp, SIGTERM, NS_JOB_PERSIST , test_client_shutdown, stp, &sigterm_job);
}}}
It looks you are commenting out from line 393 through 410. Is it intentional?
{{{
393 / cmocka_unit_test_setup_teardown(ns_init_test,
........................
410 ns_test_teardown),
/
}}}
These are trivial question/request. The main part of the fix looks good and acked.

commit c77ea84
Writing objects: 100% (8/8), 1.27 KiB | 0 bytes/s, done.
Total 8 (delta 6), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/nunc-stans.git
36a71ec..c77ea84 master -> master

I have made the two fixes you suggested, I knew I was forgetting something (To undo-the comment).

Login to comment on this ticket.

Metadata