#1 dutil_posix.c:225]: (style) Suspicious condition
Opened 5 years ago by dcb. Modified 5 years ago

dutil_posix.c:225]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

while ((waitret = waitpid(childpid, &exitstatus, 0) == -1) &&
       errno == EINTR) {

Maybe better code

while (((waitret = waitpid(childpid, &exitstatus, 0)) == -1) &&
       errno == EINTR) {

Login to comment on this ticket.

Metadata