modulemd

#27 Add the commit field to contain a modulemd's commit hash
Closed by mprahl. Opened by mprahl.
Unknown source master

Download 27.patch

This adds an optional "commit" field to contain the commit hash of the modulemd. This is to be filled in after the modulemd is submitted to the Module Build Service (MBS) by the MBS.

The purpose for this is to allow for easy auditing as to which module build is tied to which commit hash of the modulemd.

If we are strict about the hash length, let's mention it in the comment below.

Something like: ...full-length SHA-1 commit hash, ....

rebased

@fivaldi thanks for reviewing. I addressed your comment.

Hmm... Two things here, I guess.

  1. ref is a misleading name as tag and branch names are also refs.
  2. The check whether the input is an SHA hash might be too strict. modulemd is meant to be VCS-agnostic and other systems might do things differently.

rebased

@psabata I renamed "ref" to "commit" and removed the strict SHA1 commit hash checking.

@psabata - do Matt's changes resolve your concerns?

Pull-Request has been closed by mprahl
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.