#26 Change type from str to dict of items in buildrequires
Closed 7 years ago by mprahl. Opened 7 years ago by mprahl.
Unknown source buildrequires-dict  into  master

No commits found

When developing on the Module Build Service, we determined we want to have the ability to have key value pairs associated with a module in buildrequires. Particularly, when a modulemd is submitted to the Module Build Service, we'd like to add the version of the module used in buildrequires. This allows us to determine if a module dependency in buildrequires has changed since the last build (an important aspect when trying to reuse previously built components).

For instance, before we would only have:

buildrequires:
    base-runtime: master

We want to be able to do something like:

buildrequires:
    base-runtime:
        stream: master
        version: 20170123140147

Additionally, I allowed for backwards compatibility in the sense that any modulemd that still uses the old format of strings instead of dictionaries, will have the buildrequires converted to a dictionary at import time. If you don't think this is useful, then I can remove this.

Generally looks good to me, still suggest an eye of another reviewer familiar with design/concept of modulemd.

My opinion: I see backward compatiility more obligatory than optional, unless modulemd version would be incremented. So, it's good to keep it there.

Looks good here too. It would be good if someone from the modularity or base-runtime teams could check this too.

Somehow this doesn't feel right to me but I can't put my finger on why.

I'll think about it a bit :)

Pull-Request has been closed by mprahl

7 years ago
Metadata