It uses python-tornado - I'm not sure if that's the right module to use. I'm OK to rewrite that to something different, but we should discuss what we should use for async http requests.
:thumbsup:
rebased
What's the reason for the double leading underscore in this method? Normally, this should only used to avoid name clashes in subclasses. I assume that _schedule_requests() has only one because name-mangling bit you in the nested wrapped() function, right? :wink:
_schedule_requests()
wrapped()
Is there a problem with simply using print() here?
print()
https://fedoraproject.org/wiki/Modularity/Development/Coding_Style#Comments_and_Docstrings :stuck_out_tongue:
NB: these are "positional" arguments (or just "arguments"). Only arguments that have a default value are called "keyword arguments" (or colloquially if you refer to positional arguments "by name" when calling the function/method).
Error status as the return value? That's too C-ish for me ;). And catching KeyboardInterrupt should normally go to the main function or block.
KeyboardInterrupt
...and here the error status isn't looked at :wink: Wrapping the collected errors above in a new exception and catching it here looks more natural to me. :smiley:
Fixed the remaining long lines (one in each code and commit log), and merged in commit 98550b68ed33b886dfebe6230f2341e50e498868.
Pull-Request has been closed by nphilipp
It uses python-tornado - I'm not sure if that's the right module to use. I'm OK to rewrite that to something different, but we should discuss what we should use for async http requests.