nss_engine_kernel.c:555]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
if ((result = ap_get_brigade(c->input_filters, bb, AP_MODE_GETLINE, APR_BLOCK_READ, HUGE_STRING_LEN) != APR_SUCCESS || APR_BRIGADE_EMPTY(bb))) {
Suggest new code
if ((result = ap_get_brigade(c->input_filters, bb, AP_MODE_GETLINE, APR_BLOCK_READ, HUGE_STRING_LEN)) != APR_SUCCESS || APR_BRIGADE_EMPTY(bb)) {
Yikes. That code is rather hard to read isn't it. How about this instead:
+ result = ap_get_brigade(c->input_filters, bb, + AP_MODE_GETLINE, APR_BLOCK_READ, HUGE_STRING_L EN); + if ((result != APR_SUCCESS) || (APR_BRIGADE_EMPTY (bb))) { apr_brigade_destroy(bb); break; }
Metadata Update from @rcritten: - Issue assigned to rcritten - Issue set to the milestone: mod_nss-1.0.15
Login to comment on this ticket.