#47 Specify in the README that the virtualenv must be py3
Merged by pingou. Opened by pingou.
fix_doc  into  master

Download 47.patch
no initial comment

1 new commit added

  • Add a fedmsg.d/mdapi.py file so it helps working in a venv

1 new commit added

  • Require all fedmsg modules

I'm not familiar with the [all] notation - what does this do?

For PEP-8, there should be two spaces between this line and the import.

LGTM as is, or you can take my PEP-8 suggestion if you like.

It installs all the fedmsg requirements: https://github.com/fedora-infra/fedmsg/blob/develop/setup.py#L95

1 new commit added

  • Small pep8 fix as suggested by @bowlofeggs

Thanks for the review, I adjusted the pep8 violation.

Merging :)

Pull-Request has been merged by pingou

Metadata