mdapi

#102 Add an option for whether to publish changes.
Merged by pingou. Opened by qulogic.
qulogic/mdapi publish-config  into  master

Download 102.patch

Running locally, there's no need to publish changes, since you don't have access to Fedora Messaging. This breaks the script halfway through since this happens before installing the database.

Can we also skip compare_dbs if not publishing changes?

rebased onto d76ae4459104eab3337ee8af846bef5b50e4c42d

Can we also skip compare_dbs if not publishing changes?

I think we could yes.

rebased onto 32542703a8a359737323c7ff856910cd45ef1ab0

OK, rebased and added that.

The default in the script is True and the default in the config here is False. For the sake of consistency and avoid breaking backward compatibility, I think it should default to True here as well.

Yes, that is somewhat intentional, though I am operating under the assumption that production instances have their own config (or are they really writing to /var/tmp?). Local clones would use the instructions and get default_config.py (without publishing), while existing configs would use the script default (with publishing) because they wouldn't have it in their settings yet. Unless prod runs default config too?
Edited by qulogic

I likely has its own config, but with this change, the default will go to False and if we're not careful suddenly it doesn't send notifications any more.

I prefer we stay backward compatible :)

rebased onto 27e0581045279cc5586dd1c434cb4662b076d44f

OK, it should be the same now.

Looks all good to me, thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.