From 9ca813337c7173e3889dc31986f3fc906a7c66c5 Mon Sep 17 00:00:00 2001 From: Lon Hohberger Date: Jun 22 2009 18:16:57 +0000 Subject: rgmanager: Don't push NULL on to the S/Lang stack Signed-off-by: Lon Hohberger --- diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c index 4f52041..86625c6 100644 --- a/rgmanager/src/daemons/slang_event.c +++ b/rgmanager/src/daemons/slang_event.c @@ -449,8 +449,15 @@ sl_service_property(char *svcName, char *prop) if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0) return; - /* does this work or do I have to push a malloce'd string? */ ret = strdup(buf); + if (!ret) { + SLang_verror(SL_RunTime_Error, + (char *)"%s: Failed to duplicate state of %s", + __FUNCTION__, + svcName); + return; + } + if (SLang_push_malloced_string(ret) < 0) { SLang_verror(SL_RunTime_Error, (char *)"%s: Failed to push %s property of %s",