#26 passing potentially negative fd to close
Closed 2 years ago Opened 2 years ago by jhrozek.

This is really not a big deal, but perhaps we could refactor the code a little to be better understandable by coverity:

#  388|     fd = open_and_copy_file(e->filename, backup_name, FALSE, error);
#  389|     g_free (backup_name);
#  390|->   close(fd);
#  391|     if (fd == -1)
#  392|         goto err_fscreate;

Maybe we could move the check before close?

Metadata Update from @jhrozek:
- Issue assigned to jhrozek

2 years ago

Metadata Update from @jhrozek:
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.