Issue #21: check the return value of getgrnam_r - libuser

libuser

#21 check the return value of getgrnam_r

Closed a year ago by thalman. Opened 5 years ago by jhrozek.

Mostly to silence the static analyzers:
libuser-0.62/lib/config.c:682: check_return: Calling "getgrnam_r(value, &grp, buf, 8192UL, &g)" without checking return value. This library function may fail and return an error code.

#  680|                 struct group grp, *g;
#  681|   
#  682|->               getgrnam_r(value, &grp, buf, sizeof(buf), &g);
#  683|                 if (g != NULL)
#  684|                     value = g->gr_name;

jhrozek commented 5 years ago

We might also fix:

# 2066|              * that's already in use by a service we can't write
# 2067|              * to, so check with NSS first. */
# 2068|->           getgrgid_r(id, &grp, buf, sizeof(buf), &err);
# 2069|             if (err == &grp) {
# 2070|                 id++;

Metadata Update from @jhrozek:
- Issue assigned to jhrozek

5 years ago