Learn more about these different git repos.
Other Git URLs
9d3a969
57fb9a9
@@ -88,7 +88,10 @@
verify=not self.insecure,
)
- output = None
+ if req.status_code == 404:
+ # TODO: use a dedicated error class
+ raise Exception("404, {} not found".format(url))
+
try:
output = req.json()
except Exception as err:
As you can see in https://github.com/packit-service/packit/issues/305 one gets a cryptic Error while decoding JSON: Expecting value: line 1 column 1 (char 0) when _call_api() requests a wrong url (for more details see https://github.com/packit-service/ogr/issues/67).
Error while decoding JSON: Expecting value: line 1 column 1 (char 0)
_call_api()
LGTM
Cool thanks @jpopelka @ttomecek do you guys want commit permissions to this project ?
Pull-Request has been merged by cverna
As @lachmanfrantisek indicated in some issue (can't find it right now) we are considering of dropping usage of libpagure and talk to pagure api directly in our ogr library.
Yes, having commit access would help us, but at the same time, we have already developed a library which we use a lot. Should we talk about this in person?
As you can see in https://github.com/packit-service/packit/issues/305 one gets a cryptic
Error while decoding JSON: Expecting value: line 1 column 1 (char 0)
when
_call_api()
requests a wrong url (for more details see https://github.com/packit-service/ogr/issues/67).