#4 Rename variables: variables starting with a capital letter are normally classes
Merged 8 years ago by yangl1996. Opened 8 years ago by pingou.
pingou/libpagure rename_vars  into  master

file modified
+54 -54
@@ -36,11 +36,11 @@ 

          :param instance_url: the URL of pagure instance name

          :return:

          """

-         self.Token = pagure_token

-         self.Repository = pagure_repository

-         self.ForkUsername = fork_username

-         self.InstanceURL = instance_url

-         self.Header = {"Authorization": "token " + self.Token}

+         self.token = pagure_token

+         self.repo = pagure_repository

+         self.username = fork_username

+         self.instance = instance_url

+         self.header = {"Authorization": "token " + self.token}

          self.session = requests.session()

          self.insecure = insecure

  
@@ -62,7 +62,7 @@ 

              method=method,

              url=url,

              params=params,

-             headers=self.Header,

+             headers=self.header,

              data=data,

              verify=not self.insecure,

          )
@@ -90,7 +90,7 @@ 

          Get Pagure API version.

          :return:

          """

-         request_url = "{}/api/0/version".format(self.InstanceURL)

+         request_url = "{}/api/0/version".format(self.instance)

          return_value = self.__call_api(request_url)

          return return_value['version']

  
@@ -100,7 +100,7 @@ 

          :param pattern: filters the starting letters of the return value

          :return:

          """

-         request_url = "{}/api/0/users".format(self.InstanceURL)

+         request_url = "{}/api/0/users".format(self.instance)

          params = None

          if pattern:

              params = {'pattern': pattern}
@@ -113,12 +113,12 @@ 

          :param pattern: filters the starting letters of the return value

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/tags".format(

-                 self.InstanceURL, self.Repository)

+                 self.instance, self.repo)

          else:

              request_url = "{}/api/0/fork/{}/{}/tags".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository)

+                 self.instance, self.username, self.repo)

          params = None

          if pattern:

              params = {'pattern': pattern}
@@ -132,7 +132,7 @@ 

          :param pattern: filters the starting letters of the return value

          :return:

          """

-         request_url = "{}/api/0/groups".format(self.InstanceURL)

+         request_url = "{}/api/0/groups".format(self.instance)

          params = None

          if pattern:

              params = {'pattern': pattern}
@@ -145,7 +145,7 @@ 

          Get a dictionary of all error codes.

          :return:

          """

-         request_url = "{}/api/0/error_codes".format(self.InstanceURL)

+         request_url = "{}/api/0/error_codes".format(self.instance)

          return_value = self.__call_api(request_url)

          return return_value

  
@@ -157,12 +157,12 @@ 

          :param author: filters the author of the requests

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-requests".format(

-                 self.InstanceURL, self.Repository)

+                 self.instance, self.repo)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-requests".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository)

+                 self.instance, self.username, self.repo)

          payload = {}

          if status is not None:

              payload['status'] = status
@@ -180,12 +180,12 @@ 

          :param request_id: the id of the request

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-request/{}".format(

-                 self.InstanceURL, self.Repository, request_id)

+                 self.instance, self.repo, request_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-request/{}".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  request_id)

  

          return_value = self.__call_api(request_url)
@@ -197,12 +197,12 @@ 

          :param request_id: the id of the request

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-request/{}/merge".format(

-                 self.InstanceURL, self.Repository, request_id)

+                 self.instance, self.repo, request_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-request/{}/merge".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  request_id)

  

          return_value = self.__call_api(request_url, method='POST')
@@ -216,12 +216,12 @@ 

          :param request_id: the id of the request

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-request/{}/close".format(

-                 self.InstanceURL, self.Repository, request_id)

+                 self.instance, self.repo, request_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-request/{}/close".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  request_id)

  

          return_value = self.__call_api(request_url, method='POST')
@@ -239,12 +239,12 @@ 

          :param row: which line of code to comment on

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-request/{}/comment".format(

-                 self.InstanceURL, self.Repository, request_id)

+                 self.instance, self.repo, request_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-request/{}/comment".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  request_id)

  

          payload = {'comment': body}
@@ -272,12 +272,12 @@ 

          :param commit: which commit to flag on

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/pull-request/{}/flag".format(

-                 self.InstanceURL, self.Repository, request_id)

+                 self.instance, self.repo, request_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/pull-request/{}/flag".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  request_id)

  

          payload = {'username': username, 'percent': percent, 'comment': comment, 'url': url}
@@ -299,12 +299,12 @@ 

          :param private: whether create this issue as private

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/new_issue".format(

-                 self.InstanceURL, self.Repository)

+                 self.instance, self.repo)

          else:

              request_url = "{}/api/0/fork/{}/{}/new_issue".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository)

+                 self.instance, self.username, self.repo)

  

          payload = {'title': title, 'issue_content': content}

          if private is not None:
@@ -324,12 +324,12 @@ 

          :param author: filters the author of the issues

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/issues".format(

-                 self.InstanceURL, self.Repository)

+                 self.instance, self.repo)

          else:

              request_url = "{}/api/0/fork/{}/{}/issues".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository)

+                 self.instance, self.username, self.repo)

  

          payload = {}

          if status is not None:
@@ -351,12 +351,12 @@ 

          :param issue_id: the id of the issue

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/issue/{}".format(

-                 self.InstanceURL, self.Repository, issue_id)

+                 self.instance, self.repo, issue_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/issue/{}".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  issue_id)

  

          return_value = self.__call_api(request_url)
@@ -370,12 +370,12 @@ 

          :param comment_id: the id of the comment

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/issue/{}/comment/{}".format(

-                 self.InstanceURL, self.Repository, issue_id, comment_id)

+                 self.instance, self.repo, issue_id, comment_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/issue/{}/comment/{}".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  issue_id, comment_id)

  

          return_value = self.__call_api(request_url)
@@ -389,12 +389,12 @@ 

          :param new_status: the new status fo the issue

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/issue/{}/status".format(

-                 self.InstanceURL, self.Repository, issue_id)

+                 self.instance, self.repo, issue_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/issue/{}/status".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  issue_id)

  

          payload = {'status': new_status}
@@ -411,12 +411,12 @@ 

          :param body: the comment body

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/issue/{}/comment".format(

-                 self.InstanceURL, self.Repository, issue_id)

+                 self.instance, self.repo, issue_id)

          else:

              request_url = "{}/api/0/fork/{}/{}/issue/{}/comment".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository,

+                 self.instance, self.username, self.repo,

                  issue_id)

  

          payload = {'comment': body}
@@ -431,12 +431,12 @@ 

          List all git tags made to the project.

          :return:

          """

-         if self.ForkUsername is None:

+         if self.username is None:

              request_url = "{}/api/0/{}/git/tags".format(

-                 self.InstanceURL, self.Repository)

+                 self.instance, self.repo)

          else:

              request_url = "{}/api/0/fork/{}/{}/git/tags".format(

-                 self.InstanceURL, self.ForkUsername, self.Repository)

+                 self.instance, self.username, self.repo)

  

          return_value = self.__call_api(request_url)

  
@@ -450,7 +450,7 @@ 

          :param fork: filters whether it is a fork (True) or not (False)

          :return:

          """

-         request_url = "{}/api/0/projects".format(self.InstanceURL)

+         request_url = "{}/api/0/projects".format(self.instance)

  

          payload = {}

          if tags is not None:
@@ -470,7 +470,7 @@ 

          :param username: the username of the user to get info about

          :return:

          """

-         request_url = "{}/api/0/user/{}".format(self.InstanceURL, username)

+         request_url = "{}/api/0/user/{}".format(self.instance, username)

  

          return_value = self.__call_api(request_url)

  

no initial comment
Metadata