There's a typo in ctl_dbtasks_test making 2 test cases to fail.
Metadata Update from @ilias95: - Issue assigned to ilias95
<img alt="0001-Issue-93-Fix-test-cases-in-ctl_dbtasks_test.py.patch" src="/lib389/issue/raw/files/1a03a98186d2d713fb306f28cf12837728454d20867aa618fe37392acf1c7ab9-0001-Issue-93-Fix-test-cases-in-ctl_dbtasks_test.py.patch" />
Metadata Update from @ilias95: - Custom field Origin adjusted to None - Custom field Review Status adjusted to None
Metadata Update from @ilias95: - Custom field Review Status adjusted to review (was: None)
Metadata Update from @spichugi: - Custom field Review Status adjusted to ack (was: review)
LGTM. Ack. Though it depends on #88...
@spichugi Why it depends on #88?
Sorry, I've just meant that you can't see the results without #88, because the test will fail (and #88 fixes it).
But technically, the commit can be pushed. Do you want me to apply it?
Hmm, I got a bit confused. I think this one is not related with #88 at all.
Like, if you do this on current master: sudo py.test-3 -s lib389/lib389/tests/cli/ctl_dbtasks_test.py
2 out of 4 test cases will fail.
But if you apply this patch (and neither #88 nor anything else) and run the same command, all 4 test cases will pass.
I don't mind. If it's indeed related with #88 for sure it can wait.
Thanks!
commit 1f1d32d To ssh://git@pagure.io/lib389.git 2a50b9d..709d572 master -> master
Metadata Update from @ilias95: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.