lib389

#92 display_attr() should return str not bytes in py3
Closed: Fixed Opened by ilias95.

Closed: Fixed
Reopen Issue

In python3 display_attr() method of mapped object returns bytes. We should make it return str instead.

Metadata Update from @ilias95:
- Issue assigned to ilias95

Metadata Update from @ilias95:
- Assignee reset

Metadata Update from @ilias95:
- Issue assigned to ilias95

Metadata Update from @ilias95:
- Custom field Origin adjusted to None
- Custom field Review Status adjusted to None

0001-Issue-92-display_attr-should-return-str-not-bytes-in.patch

Metadata Update from @ilias95:
- Custom field Review Status adjusted to review (was: None)

There is an extra bug actually. get_attr_vals_type() functions call a non-existing method due to a typo.

They call get_attrs_val() but this method does not exist.
Instead the following two methods exist:

  1. get_attr_vals -> https://pagure.io/lib389/blob/master/f/lib389/_mapped_object.py#_322
  2. get_attrs_vals -> https://pagure.io/lib389/blob/master/f/lib389/_mapped_object.py#_314

I'm not sure what is the difference between these 2 and I chose to go with the first one, but please make sure it is the one we want.

get_attr_vals I think was get 1 attribute and many values, and get_attrs_vals was get many attributes with many values (I think).

Okay, so the patch should be fine I think then.

commit d304445ad9007dc892a4d6dcbed1b1cfece2a24c
To ssh://git@pagure.io/lib389.git
2a50b9d..709d572 master -> master

Metadata Update from @ilias95:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
review
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.