Was already requested by a comment. By using os.path.join we make the paths platform independent. <img alt="0001-Ticket-24-Join-paths-using-os.path.join-instead-of-s.patch" src="/lib389/issue/raw/files/1ed734a1914fec4f4bef5d4f59bdfb084ff02b0e73dbcc79f165bb0c6e07f125-0001-Ticket-24-Join-paths-using-os.path.join-instead-of-s.patch" />
Metadata Update from @ilias95: - Issue assigned to ilias95
I think it works with just:
os.path.join(self.krb_prefix, 'usr/sbin/kadmin.local')
Which might be nicer to read and maintain :)
I think that the whole point of using os.path.join is to avoid putting any slashes in the path to make the program platform independent. If we don't care for this that's fine.
Apart from this, the one you wrote wouldn't work because self.krb_prefix is en empty string at the moment, which would result in a relative path:
>>> os.path.join('', 'usr/sbin/kadmin.local') 'usr/sbin/kadmin.local'
But it can work like this:
os.path.join(os.path.sep, self.krb_prefix, 'usr/sbin/kadmin.local')
If we don't really care for it being platform independent we may as well ignore it and leave it as it is.
I think that we have no interest in supporting this library on windows at the moment, so yeah, I don't mind this at all.
I thought that python also knew in most calls to translate / to \ for windows anyway.
I think I prefix the option you present at the end here. Thanks!
<img alt="0001-Issue-24-Join-paths-using-os.path.join-instead-of-st.patch" src="/lib389/issue/raw/files/6d40d7ebb39e6838f3ff6749d4cb3af931b086d7f7f0c799907b5a87b530d11b-0001-Issue-24-Join-paths-using-os.path.join-instead-of-st.patch" />
Metadata Update from @firstyear: - Custom field Review Status adjusted to ack
commit 0fe0ea9 To ssh://git@pagure.io/lib389.git 2da3366..0fe0ea9 master -> master
Metadata Update from @firstyear: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.