Hi Simon, please go ahead and change the code as per your requirement.

Hi Sankar,
sure, no problem.

Seems to me the test file renames should be in a separate commit.

@rcritten I'm happy for the test renames to be here, it's not a big deal or a big change. This is still a bit of a moving target so it's okay.

As for the actual change itself, @spichugi this bit of code has always irked me a little because basedn needs to be "ou=People,<backend dn>", but there was never a good way to change it. My way wasn't very good, but you could do it with:

ua = UserAccounts(..., basedn=dc=example,dc=com)
ua._basedn= ....

But it's not good to tamper with these internals.

At the same time, I'm not sure I like the extra parameter: But I don't know a better option. Because really, we now have two parameters that change the basedn, and it's not clear if basedn means the userbasedn or the server basedn, and what rdn does.

So I like the "idea" of the change, but I wonder if we can come up with a better way? If not, I think I would be happy to accept this change as is, because it also doesn't break any existing code.

@rcritten I'm happy for the test renames to be here, it's not a big deal or a big change. This is still a bit of a moving target so it's okay.
As for the actual change itself, @spichugi this bit of code has always irked me a little because basedn needs to be "ou=People,<backend dn>", but there was never a good way to change it. My way wasn't very good, but you could do it with:
ua = UserAccounts(..., basedn=dc=example,dc=com)
ua._basedn= ....

But it's not good to tamper with these internals.
At the same time, I'm not sure I like the extra parameter: But I don't know a better option. Because really, we now have two parameters that change the basedn, and it's not clear if basedn means the userbasedn or the server basedn, and what rdn does.
So I like the "idea" of the change, but I wonder if we can come up with a better way? If not, I think I would be happy to accept this change as is, because it also doesn't break any existing code.

@firstyear I agree with you and my first desire was to rewrite more stuff. :)
Basically, what I think we can do it is to change basedn='dc=examle,dc=com' to the basedn='ou=people,dc=example,dc=com' accordingly in all modules. It makes more sense because then we will work just with one string as we do in the majority of ldap tools.

For this, though, I'll need to rewrite lib389/cli utils. If you are okay with that I'll go for it.

But the issue then is we have tools like dsidm that don't use dc=example,dc=com by default. we need to change this relatie to ou=People.....

So for now, I think your solution is best, until we can do something better :)

But the issue then is we have tools like dsidm that don't use dc=example,dc=com by default. we need to change this relatie to ou=People.....
So for now, I think your solution is best, until we can do something better :)

Okay. Let's improve this part later. May be someone from GSoC will join. :)

To ssh://pagure.io/lib389.git
b9d2a14..8f61549 master -> master
commit 8f61549
Author: Simon Pichugin spichugi@redhat.com
Date: Tue Apr 11 22:47:14 2017 +0200