While writing some test, by mistake I used topo instead of topo.standalone to access the instance with DSLdapObject function and it gave me error like this ->
super(DSLdapObject, self).__init__(self._instance.verbose) E AttributeError: 'TopologyMain' object has no attribute 'verbose' /opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/lib389/_mapped_object.py:96: AttributeError
super(DSLdapObject, self).__init__(self._instance.verbose)
E AttributeError: 'TopologyMain' object has no attribute 'verbose' /opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/lib389/_mapped_object.py:96: AttributeError
It will be good to Assert that dsLdapObjects instances are of type dirsrv, to make it easier to find.
Metadata Update from @firstyear: - Issue assigned to firstyear
<img alt="0001-Ticket-106-lib389-assert-objects-are-correctly-typed.patch" src="/lib389/issue/raw/files/6aba20d7343dae51f09c96ff5b18ad58cfe416478eee93caa68604f0d07581c8-0001-Ticket-106-lib389-assert-objects-are-correctly-typed.patch" />
Metadata Update from @firstyear: - Custom field Origin adjusted to None - Custom field Review Status adjusted to review
lgtm
PS. Awesome that they added a static typing model.
Yeah, I'm really excited about it myself.
@spichugi Can you look over this too?
I'd rather postpone the merge until the end of the testing phase. We still haven't ported all test cases to Python 3. So sometimes we need to check if the issue we have is related to Python 2-3, test itself or DS bug.
Also, we need to clean Python requirements for lib389 (the change is Python =>3.6 only)
Yeah, that's no problem. I'll leave this for then.
Login to comment on this ticket.