bb33c27 NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro

3 files Authored by lersek 2 years ago, Committed by mergify[bot] 2 years ago,
    NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro
    
    Introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro for NetworkPkg.
    When explicitly set to FALSE, remove MD5 from IScsiDxe's CHAP algorithm
    list.
    
    Set NETWORK_ISCSI_MD5_ENABLE to TRUE by default, for compatibility
    reasons. Not just to minimize the disruption for platforms that currently
    include IScsiDxe, but also because RFC 7143 mandates MD5 for CHAP, and
    some vendors' iSCSI targets support MD5 only.
    
    With MD5 enabled, IScsiDxe will suggest SHA256, and then fall back to MD5
    if the target requests it. With MD5 disabled, IScsiDxe will suggest
    SHA256, and break off the connection (and session) if the target doesn't
    support SHA256.
    
    Cc: Jiaxin Wu <jiaxin.wu@intel.com>
    Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
    Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
    Cc: Siyuan Fu <siyuan.fu@intel.com>
    Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
    Signed-off-by: Laszlo Ersek <lersek@redhat.com>
    Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
    Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20210629163337.14120-7-lersek@redhat.com>