b4e5807 MdeModulePkg/PartitionDxe: remove always false comparison

Authored and Committed by lersek 6 years ago
    MdeModulePkg/PartitionDxe: remove always false comparison
    
    In the expression
    
      (RemainderByMediaBlockSize != 0 ||
       Media->BlockSize > UDF_LOGICAL_SECTOR_SIZE)
    
    the second expression is only evaluated if the first expression is false.
    
    If the first expression is false, i.e.,
    
      RemainderByMediaBlockSize == 0
    
    then UDF_LOGICAL_SECTOR_SIZE is a whole multiple of "Media->BlockSize",
    which implies
    
      UDF_LOGICAL_SECTOR_SIZE >= Media->BlockSize.
    
    Therefore whenever
    
      Media->BlockSize > UDF_LOGICAL_SECTOR_SIZE
    
    is evaluated, it is false.
    
    The expression
    
      ((expression) || FALSE)
    
    is equivalent to
    
      (expression).
    
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Paulo Alcantara <pcacjr@zytor.com>
    Cc: Ruiyu Ni <ruiyu.ni@intel.com>
    Cc: Star Zeng <star.zeng@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Laszlo Ersek <lersek@redhat.com>
    Reviewed-by: Star Zeng <star.zeng@intel.com>
    Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>
    Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>