| |
@@ -2669,10 +2669,18 @@
|
| |
insert = InsertProcessor('tag_updates', data=data)
|
| |
insert.execute()
|
| |
|
| |
+ def _validate_build_target_name(name):
|
| |
+ """ A helper function that validates a build target name. """
|
| |
+ max_name_length = 256
|
| |
+ if len(name) > max_name_length:
|
| |
+ raise koji.GenericError("Build target name %s is too long. Max length "
|
| |
+ "is %s characters" % (name, max_name_length))
|
| |
+
|
| |
def create_build_target(name, build_tag, dest_tag):
|
| |
"""Create a new build target"""
|
| |
|
| |
context.session.assertPerm('admin')
|
| |
+ _validate_build_target_name(name)
|
| |
|
| |
# Does a target with this name already exist?
|
| |
if get_build_targets(info=name):
|
| |
@@ -2702,6 +2710,7 @@
|
| |
def edit_build_target(buildTargetInfo, name, build_tag, dest_tag):
|
| |
"""Set the build_tag and dest_tag of an existing build_target to new values"""
|
| |
context.session.assertPerm('admin')
|
| |
+ _validate_build_target_name(name)
|
| |
|
| |
target = lookup_build_target(buildTargetInfo)
|
| |
if not target:
|
| |
mprahl
commented 4 years ago
The tag name length restriction was increased to 256 characters last year [1]. Because of this, MBS started using more informative tag names [2] but it turns out that the tag name is also used to create the build target. We'd like to keep the naming consistent and to do this, we must increases the length restriction on build target names.
1 - https://pagure.io/koji/c/d9280d694501afb2df6c12b3f9778beb73f350a0?branch=master
2 - https://pagure.io/fm-orchestrator/issue/918