#924 kojixmlrpc: Handle unknown context.method
Closed 4 years ago by tkopecek. Opened 5 years ago by till.
till/koji xmlrpc  into  master

file modified
+9 -1
@@ -744,7 +744,15 @@ 

                  paramstr = repr(getattr(context, 'params', 'UNKNOWN'))

                  if len(paramstr) > 120:

                      paramstr = paramstr[:117] + "..."

-                 h.logger.warning("Memory usage of process %d grew from %d KiB to %d KiB (+%d KiB) processing request %s with args %s" % (os.getpid(), memory_usage_at_start, memory_usage_at_end, memory_usage_at_end - memory_usage_at_start, context.method, paramstr))

+                 method = getattr(context, 'method', 'UNKNOWN')

+                 h.logger.warning(

+                     "Memory usage of process %d grew from %d KiB to "

+                     "%d KiB (+%d KiB) processing request %s with args %s" % (

+                         os.getpid(), memory_usage_at_start,

+                         memory_usage_at_end,

+                         memory_usage_at_end - memory_usage_at_start,

+                         method, paramstr)

+                 )

              h.logger.debug("Returning %d bytes after %f seconds", len(response),

                          time.time() - start)

          finally:

This triggered an error a long time ago and I forgot to push this here.

HubFormatter should provide the method, though it sets it to None instead of "UNKNOWN". Do you recall how you managed to get the error? Maybe we need a deeper fix here.

Pull-Request has been closed by tkopecek

4 years ago