#860 mavenBuild uses wrong session
Merged 5 years ago by mikem. Opened 6 years ago by tkopecek.
tkopecek/koji issue859  into  master

file modified
+1 -1
@@ -1417,7 +1417,7 @@ 

          repo_info = self.session.repoInfo(repo_id, strict=True)

          event_id = repo_info['create_event']

  

-         br_arch = self.find_arch('noarch', self.session.host.getHost(), session.getBuildConfig(build_tag['id'], event=event_id))

+         br_arch = self.find_arch('noarch', self.session.host.getHost(), self.session.getBuildConfig(build_tag['id'], event=event_id))

          maven_opts = opts.get('jvm_options')

          if not maven_opts:

              maven_opts = []

I wonder, that nobody hit this. I'm not able to run mavenBuild on my dev machine and it is breaking with quite cryptic message

Error: [('SSL routines', 'ssl3_get_record', 'decryption failed or bad record mac')]

I don't think anyone in the community is using the maven build feature.

The call in question is read-only, so it doesn't matter that the session we're using has had _forget() called on it (in forkTask).

I suspect the failure you're seeing has to do with the underlying requests session getting used by both processes. Possibly the connection been closed and replaced by the main process or something. OTOH, the _sendCall function should always give one retry and can new_session when it does.

Certainly, the fix is correct, but I'm curious about the issue and what else might be lurking here.

How reliably can you reproduce this? Does it happen every time?

Ah, I can reproduce this with a simple script

We should probably also call new_session in _forget()

Commit c9d827f fixes this pull-request

Pull-Request has been merged by mikem

5 years ago
Metadata